--- embedaddon/sudo/plugins/sudoers/boottime.c 2012/02/21 16:23:02 1.1 +++ embedaddon/sudo/plugins/sudoers/boottime.c 2014/06/15 16:12:54 1.1.1.4 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009-2011 Todd C. Miller + * Copyright (c) 2009-2013 Todd C. Miller * * Permission to use, copy, modify, and distribute this software for any * purpose with or without fee is hereby granted, provided that the above @@ -16,7 +16,6 @@ #include -#include #include #include @@ -29,6 +28,11 @@ # include # endif #endif /* STDC_HEADERS */ +#ifdef HAVE_STDBOOL_H +# include +#else +# include "compat/stdbool.h" +#endif /* HAVE_STDBOOL_H */ #ifdef HAVE_STRING_H # if defined(HAVE_MEMORY_H) && !defined(STDC_HEADERS) # include @@ -39,7 +43,7 @@ # include #endif /* HAVE_STRINGS_H */ #include -#if TIME_WITH_SYS_TIME +#ifdef TIME_WITH_SYS_TIME # include #endif #ifndef __linux__ @@ -53,6 +57,7 @@ #endif /* !__linux__ */ #include "missing.h" +#include "sudo_debug.h" /* * Fill in a struct timeval with the time the system booted. @@ -60,46 +65,53 @@ */ #if defined(__linux__) -int +bool get_boottime(struct timeval *tv) { - char *line = NULL; + char *ep, *line = NULL; size_t linesize = 0; + bool found = false; ssize_t len; - FILE * fp; + FILE *fp; + debug_decl(get_boottime, SUDO_DEBUG_UTIL) /* read btime from /proc/stat */ fp = fopen("/proc/stat", "r"); if (fp != NULL) { while ((len = getline(&line, &linesize, fp)) != -1) { if (strncmp(line, "btime ", 6) == 0) { - tv->tv_sec = atoi(line + 6); - tv->tv_usec = 0; - return 1; + long long llval = strtonum(line + 6, 1, LLONG_MAX, NULL); + if (llval > 0) { + tv->tv_sec = (time_t)llval; + tv->tv_usec = 0; + found = true; + break; + } } } fclose(fp); free(line); } - return 0; + debug_return_bool(found); } #elif defined(HAVE_SYSCTL) && defined(KERN_BOOTTIME) -int +bool get_boottime(struct timeval *tv) { size_t size; int mib[2]; + debug_decl(get_boottime, SUDO_DEBUG_UTIL) mib[0] = CTL_KERN; mib[1] = KERN_BOOTTIME; size = sizeof(*tv); if (sysctl(mib, 2, tv, &size, NULL, 0) != -1) - return 1; + debug_return_bool(true); - return 0; + debug_return_bool(false); } #elif defined(HAVE_GETUTXID) @@ -108,6 +120,7 @@ int get_boottime(struct timeval *tv) { struct utmpx *ut, key; + debug_decl(get_boottime, SUDO_DEBUG_UTIL) memset(&key, 0, sizeof(key)); key.ut_type = BOOT_TIME; @@ -117,7 +130,7 @@ get_boottime(struct timeval *tv) tv->tv_usec = ut->ut_tv.tv_usec; } endutxent(); - return ut != NULL; + debug_return_bool(ut != NULL); } #elif defined(HAVE_GETUTID) @@ -126,6 +139,7 @@ int get_boottime(struct timeval *tv) { struct utmp *ut, key; + debug_decl(get_boottime, SUDO_DEBUG_UTIL) memset(&key, 0, sizeof(key)); key.ut_type = BOOT_TIME; @@ -135,7 +149,7 @@ get_boottime(struct timeval *tv) tv->tv_usec = 0; } endutent(); - return ut != NULL; + debug_return_bool(ut != NULL); } #else @@ -143,6 +157,7 @@ get_boottime(struct timeval *tv) int get_boottime(struct timeval *tv) { - return 0; + debug_decl(get_boottime, SUDO_DEBUG_UTIL) + debug_return_bool(false); } #endif