--- embedaddon/sudo/plugins/sudoers/bsm_audit.c 2012/05/29 12:26:49 1.1.1.2 +++ embedaddon/sudo/plugins/sudoers/bsm_audit.c 2013/10/14 07:56:34 1.1.1.4 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009-2011 Todd C. Miller + * Copyright (c) 2009-2013 Todd C. Miller * Copyright (c) 2009 Christian S.J. Peron * * Permission to use, copy, modify, and distribute this software for any @@ -30,8 +30,9 @@ #include #include +#include "missing.h" +#include "fatal.h" #include "gettext.h" -#include "error.h" #include "sudo_debug.h" #include "bsm_audit.h" @@ -57,10 +58,10 @@ audit_sudo_selected(int sf) if (getaudit_addr(&ainfo_addr, sizeof(ainfo_addr)) < 0) { if (errno == ENOSYS) { if (getaudit(&ainfo) < 0) - error(1, _("getaudit: failed")); + fatal("getaudit"); mask = &ainfo.ai_mask; } else - error(1, _("getaudit: failed")); + fatal("getaudit"); } else mask = &ainfo_addr.ai_mask; sorf = (sf == 0) ? AU_PRS_SUCCESS : AU_PRS_FAILURE; @@ -87,7 +88,7 @@ bsm_audit_success(char **exec_args) if (auditon(A_GETCOND, (caddr_t)&au_cond, sizeof(long)) < 0) { if (errno == AUDIT_NOT_CONFIGURED) return; - error(1, _("Could not determine audit condition")); + fatal(_("Could not determine audit condition")); } if (au_cond == AUC_NOAUDIT) debug_return; @@ -98,9 +99,9 @@ bsm_audit_success(char **exec_args) if (!audit_sudo_selected(0)) debug_return; if (getauid(&auid) < 0) - error(1, _("getauid failed")); + fatal("getauid"); if ((aufd = au_open()) == -1) - error(1, _("au_open: failed")); + fatal("au_open"); if (getaudit_addr(&ainfo_addr, sizeof(ainfo_addr)) == 0) { tok = au_to_subject_ex(auid, geteuid(), getegid(), getuid(), getuid(), pid, pid, &ainfo_addr.ai_termid); @@ -109,24 +110,28 @@ bsm_audit_success(char **exec_args) * NB: We should probably watch out for ERANGE here. */ if (getaudit(&ainfo) < 0) - error(1, _("getaudit: failed")); + fatal("getaudit"); tok = au_to_subject(auid, geteuid(), getegid(), getuid(), getuid(), pid, pid, &ainfo.ai_termid); } else - error(1, _("getaudit: failed")); + fatal("getaudit"); if (tok == NULL) - error(1, _("au_to_subject: failed")); + fatal("au_to_subject"); au_write(aufd, tok); tok = au_to_exec_args(exec_args); if (tok == NULL) - error(1, _("au_to_exec_args: failed")); + fatal("au_to_exec_args"); au_write(aufd, tok); tok = au_to_return32(0, 0); if (tok == NULL) - error(1, _("au_to_return32: failed")); + fatal("au_to_return32"); au_write(aufd, tok); +#ifdef __sun + if (au_close(aufd, 1, AUE_sudo, 0) == -1) +#else if (au_close(aufd, 1, AUE_sudo) == -1) - error(1, _("unable to commit audit record")); +#endif + fatal(_("unable to commit audit record")); debug_return; } @@ -147,46 +152,50 @@ bsm_audit_failure(char **exec_args, char const *const /* * If we are not auditing, don't cut an audit record; just return. */ - if (auditon(A_GETCOND, &au_cond, sizeof(long)) < 0) { + if (auditon(A_GETCOND, (caddr_t)&au_cond, sizeof(long)) < 0) { if (errno == AUDIT_NOT_CONFIGURED) debug_return; - error(1, _("Could not determine audit condition")); + fatal(_("Could not determine audit condition")); } if (au_cond == AUC_NOAUDIT) debug_return; if (!audit_sudo_selected(1)) debug_return; if (getauid(&auid) < 0) - error(1, _("getauid: failed")); + fatal("getauid"); if ((aufd = au_open()) == -1) - error(1, _("au_open: failed")); + fatal("au_open"); if (getaudit_addr(&ainfo_addr, sizeof(ainfo_addr)) == 0) { tok = au_to_subject_ex(auid, geteuid(), getegid(), getuid(), getuid(), pid, pid, &ainfo_addr.ai_termid); } else if (errno == ENOSYS) { if (getaudit(&ainfo) < 0) - error(1, _("getaudit: failed")); + fatal("getaudit"); tok = au_to_subject(auid, geteuid(), getegid(), getuid(), getuid(), pid, pid, &ainfo.ai_termid); } else - error(1, _("getaudit: failed")); + fatal("getaudit"); if (tok == NULL) - error(1, _("au_to_subject: failed")); + fatal("au_to_subject"); au_write(aufd, tok); tok = au_to_exec_args(exec_args); if (tok == NULL) - error(1, _("au_to_exec_args: failed")); + fatal("au_to_exec_args"); au_write(aufd, tok); (void) vsnprintf(text, sizeof(text), fmt, ap); tok = au_to_text(text); if (tok == NULL) - error(1, _("au_to_text: failed")); + fatal("au_to_text"); au_write(aufd, tok); tok = au_to_return32(EPERM, 1); if (tok == NULL) - error(1, _("au_to_return32: failed")); + fatal("au_to_return32"); au_write(aufd, tok); +#ifdef __sun + if (au_close(aufd, 1, AUE_sudo, PAD_FAILURE) == -1) +#else if (au_close(aufd, 1, AUE_sudo) == -1) - error(1, _("unable to commit audit record")); +#endif + fatal(_("unable to commit audit record")); debug_return; }