--- embedtools/src/vap.c 2010/10/28 15:45:27 1.1.2.6 +++ embedtools/src/vap.c 2011/06/08 12:45:41 1.2 @@ -34,13 +34,13 @@ wifi_chkIface(const char *csVAP, char **ppsIF, int nIF assert(csVAP); if (wifi_getParent(csVAP, szParent, IFNAMSIZ) == -1) - return -1; + return 0; for (i = 0; i < nIF; i++) if (!strcasecmp(ppsIF[i], "any") || !strcmp(ppsIF[i], szParent)) return 1; /* OK, vap is child */ - syslog(LOG_ERR, "Error:: Interface %s parent %s not being monitored", csVAP, szParent); + VERB(2) syslog(LOG_ERR, "Error:: Interface %s parent %s not being monitored", csVAP, szParent); return 0; } @@ -96,10 +96,12 @@ wifi_buildWDS(int fd, char **ppsIF, int nIF) struct ether_addr bssid; register int i; + FTRACE(5); + for (i = 0; i < 128; i++) { memset(szVAP, 0, IFNAMSIZ); snprintf(szVAP, IFNAMSIZ, "wlan%d", i); - if (wifi_chkIface(szVAP, ppsIF, nIF) > 0 && wifi_isWDS(fd, szVAP) > 0) { + if (wifi_chkIface(szVAP, ppsIF, nIF) && !wifi_isWDS(fd, szVAP)) { p = malloc(sizeof(struct dwds_if)); if (!p) { syslog(LOG_ERR, "Error:: can`t allocate memory #%d - %s\n", @@ -109,7 +111,8 @@ wifi_buildWDS(int fd, char **ppsIF, int nIF) } strlcpy(p->if_name, szVAP, IFNAMSIZ); if (wifi_getBSSID(fd, szVAP, p->if_bssid, IEEE80211_ADDR_LEN) == -1) { - free(p); + syslog(LOG_ERR, "Error:: can`t get BSSID #%d - %s\n", + errno, strerror(errno)); i = -1; break; } @@ -135,6 +138,8 @@ wifi_destroyWDS(const char *csIface, struct dwds_if ** { struct dwds_if *p, **pp; + FTRACE(5); + assert(csIface); assert(wds); @@ -156,6 +161,8 @@ wifi_vapDestroy(const char *csVAP) struct ieee80211req ifr; int s; + FTRACE(5); + assert(csVAP); s = socket(PF_INET, SOCK_DGRAM, 0); @@ -177,17 +184,21 @@ wifi_vapDestroy(const char *csVAP) } inline int -wifi_leaveWDS(struct ether_addr bssid, struct dwds_if **wds) +wifi_leaveWDS(struct ether_addr bssid, struct dwds_if **wds, char *psVAP, int vapLen) { struct dwds_if *p, **pp; + FTRACE(5); + assert(wds); + assert(psVAP); for (pp = wds; (p = *pp); pp = &p->if_next) if (!memcmp(p->if_bssid, &bssid, IEEE80211_ADDR_LEN)) break; if (p) { *pp = p->if_next; + strlcpy(psVAP, p->if_name, vapLen); if (wifi_vapDestroy(p->if_name) != -1) VERB(1) syslog(LOG_INFO, "BSSID:%s WDS VAP %s destroyed\n", ether_ntoa(&bssid), p->if_name); @@ -206,6 +217,8 @@ wifi_vapCreate(const char *csIface, struct dwds_if *p) struct ether_addr bssid; int s; + FTRACE(5); + assert(csIface); assert(p); @@ -244,6 +257,8 @@ wifi_createWDS(const char *csIface, struct ether_addr struct dwds_if *p; char szParent[IFNAMSIZ]; + FTRACE(5); + assert(csIface); assert(wds); @@ -264,7 +279,7 @@ wifi_createWDS(const char *csIface, struct ether_addr return -1; } else memcpy(p->if_bssid, &bssid, IEEE80211_ADDR_LEN); - if (wifi_vapCreate(csIface, p) == -1) { + if (wifi_vapCreate(szParent, p) == -1) { free(p); return -1; } else {