--- libaitmqtt/src/conn.c 2012/06/20 09:17:28 1.1.1.1.2.5 +++ libaitmqtt/src/conn.c 2022/09/13 20:37:21 1.3.12.1 @@ -3,7 +3,7 @@ * by Michael Pounov * * $Author: misho $ -* $Id: conn.c,v 1.1.1.1.2.5 2012/06/20 09:17:28 misho Exp $ +* $Id: conn.c,v 1.3.12.1 2022/09/13 20:37:21 misho Exp $ * ************************************************************************** The ELWIX and AITNET software is distributed under the following @@ -67,7 +67,8 @@ mqtt_msgCONNECT(mqtt_msg_t * __restrict buf, const cha const char *csWillTopic, const char *csWillMessage, u_char ClrSess, u_char WillQOS, u_char WillRetain) { - int n, len, siz = 0; + int len, siz = 0; + u_int n, *l; struct mqtthdr *hdr; mqtthdr_var_t *var, *cid, *topic, *wmsg, *user, *pass; mqtthdr_protover_t *proto; @@ -77,16 +78,19 @@ mqtt_msgCONNECT(mqtt_msg_t * __restrict buf, const cha if (!buf || !csConnID) return -1; - if (strlen(csConnID) > 23) { - mqtt_SetErr(EINVAL, "Invalid argument ConnID is too long (max 23 bytes)"); + if (strlen(csConnID) >= MQTT_CONNID_MAX) { + mqtt_SetErr(EINVAL, "Invalid argument ConnID is too long (max %d bytes)", + MQTT_CONNID_MAX - 1); return -1; } - if (csUser && strlen(csUser) > 12) { - mqtt_SetErr(EINVAL, "Invalid argument Username is too long (max 12 bytes)"); + if (csUser && strlen(csUser) >= MQTT_CRED_MAX) { + mqtt_SetErr(EINVAL, "Invalid argument Username is too long (max %d bytes)", + MQTT_CRED_MAX - 1); return -1; } - if (csPass && strlen(csPass) > 12) { - mqtt_SetErr(EINVAL, "Invalid argument Password is too long (max 12 bytes)"); + if (csPass && strlen(csPass) >= MQTT_CRED_MAX) { + mqtt_SetErr(EINVAL, "Invalid argument Password is too long (max %d bytes)", + MQTT_CRED_MAX - 1); return -1; } if (WillQOS > MQTT_QOS_EXACTLY) { @@ -120,10 +124,10 @@ mqtt_msgCONNECT(mqtt_msg_t * __restrict buf, const cha } /* fixed header */ - printf("%p - %p\n", hdr, data); MQTTHDR_MSGINIT(hdr); hdr->mqtt_msg.type = MQTT_TYPE_CONNECT; - *(u_int*) hdr->mqtt_len = n; + l = (u_int*) hdr->mqtt_len; + *l = n; data += siz; /* variable header */