--- libaitmqtt/src/pub.c 2012/06/20 15:02:24 1.2 +++ libaitmqtt/src/pub.c 2013/05/26 20:27:58 1.3.8.1 @@ -3,7 +3,7 @@ * by Michael Pounov * * $Author: misho $ -* $Id: pub.c,v 1.2 2012/06/20 15:02:24 misho Exp $ +* $Id: pub.c,v 1.3.8.1 2013/05/26 20:27:58 misho Exp $ * ************************************************************************** The ELWIX and AITNET software is distributed under the following @@ -12,7 +12,7 @@ terms: All of the documentation and software included in the ELWIX and AITNET Releases is copyrighted by ELWIX - Sofia/Bulgaria -Copyright 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 +Copyright 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 by Michael Pounov . All rights reserved. Redistribution and use in source and binary forms, with or without @@ -64,7 +64,7 @@ mqtt_msgPUBLISH(mqtt_msg_t * __restrict buf, const cha u_char Dup, u_char QOS, u_char Retain, const void *pData, int datlen) { int len, siz; - u_int n; + u_int n, *l; struct mqtthdr *hdr; mqtthdr_var_t *topic; mqtt_len_t *mid; @@ -104,7 +104,8 @@ mqtt_msgPUBLISH(mqtt_msg_t * __restrict buf, const cha hdr->mqtt_msg.qos = QOS; hdr->mqtt_msg.dup = Dup ? 1 : 0; hdr->mqtt_msg.retain = Retain ? 1 : 0; - *(u_int*) hdr->mqtt_len = n; + l = (u_int*) hdr->mqtt_len; + *l = n; data += siz; /* variable header */ @@ -127,7 +128,7 @@ mqtt_msgPUBLISH(mqtt_msg_t * __restrict buf, const cha static int _mqtt_msgPUB_(mqtt_msg_t * __restrict buf, u_char cmd, u_short msgID) { - int siz = 0; + int siz = sizeof(struct mqtthdr); struct mqtthdr *hdr; mqtt_len_t *v; @@ -136,12 +137,8 @@ _mqtt_msgPUB_(mqtt_msg_t * __restrict buf, u_char cmd, if (mqtt_msgRealloc(buf, sizeof(struct mqtthdr) + sizeof(mqtt_len_t)) == -1) return -1; - else { - hdr = (struct mqtthdr *) (buf->msg_base + siz); - siz += sizeof(struct mqtthdr); - v = (mqtt_len_t*) (buf->msg_base + siz); - siz += sizeof(mqtt_len_t); - } + else + hdr = (struct mqtthdr *) buf->msg_base; /* fixed header */ MQTTHDR_MSGINIT(hdr); @@ -149,7 +146,9 @@ _mqtt_msgPUB_(mqtt_msg_t * __restrict buf, u_char cmd, *hdr->mqtt_len = sizeof(mqtt_len_t); /* MessageID */ + v = (mqtt_len_t*) (buf->msg_base + siz); v->val = htons(msgID); + siz += sizeof(mqtt_len_t); return siz; } @@ -161,7 +160,7 @@ _mqtt_msgPUB_(mqtt_msg_t * __restrict buf, u_char cmd, * @msgID = MessageID * return: -1 error or >-1 message size for send */ -inline int +int mqtt_msgPUBACK(mqtt_msg_t * __restrict buf, u_short msgID) { return _mqtt_msgPUB_(buf, MQTT_TYPE_PUBACK, msgID); @@ -174,7 +173,7 @@ mqtt_msgPUBACK(mqtt_msg_t * __restrict buf, u_short ms * @msgID = MessageID * return: -1 error or >-1 message size for send */ -inline int +int mqtt_msgPUBREC(mqtt_msg_t * __restrict buf, u_short msgID) { return _mqtt_msgPUB_(buf, MQTT_TYPE_PUBREC, msgID); @@ -187,7 +186,7 @@ mqtt_msgPUBREC(mqtt_msg_t * __restrict buf, u_short ms * @msgID = MessageID * return: -1 error or >-1 message size for send */ -inline int +int mqtt_msgPUBREL(mqtt_msg_t * __restrict buf, u_short msgID) { return _mqtt_msgPUB_(buf, MQTT_TYPE_PUBREL, msgID); @@ -200,7 +199,7 @@ mqtt_msgPUBREL(mqtt_msg_t * __restrict buf, u_short ms * @msgID = MessageID * return: -1 error or >-1 message size for send */ -inline int +int mqtt_msgPUBCOMP(mqtt_msg_t * __restrict buf, u_short msgID) { return _mqtt_msgPUB_(buf, MQTT_TYPE_PUBCOMP, msgID);