--- mqtt/src/pubmqtt.c 2012/04/25 12:04:30 1.2.2.5 +++ mqtt/src/pubmqtt.c 2012/05/08 13:04:02 1.2.2.7 @@ -40,10 +40,6 @@ mqtt_rtlm_open(cfg_root_t *cfg) if (!cfg) return NULL; - sqlite3_config(SQLITE_CONFIG_SERIALIZED); - if (!sqlite3_threadsafe()) - return NULL; - str = cfg_getAttribute(cfg, "mqtt_pub", "name"); if (!str) { mqtt_rtlm_log("Error:: Unknown database name ...\n"); @@ -56,14 +52,11 @@ mqtt_rtlm_open(cfg_root_t *cfg) return NULL; } - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_exec(sql, sql_schema, NULL, NULL, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); sqlite3_close(sql); return NULL; } - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return sql; } @@ -121,10 +114,8 @@ mqtt_rtlm_init_session(cfg_root_t *cfg, sqlite3 *sql, va_end(lst); } - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -135,7 +126,6 @@ mqtt_rtlm_init_session(cfg_root_t *cfg, sqlite3 *sql, ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -168,10 +158,8 @@ mqtt_rtlm_fini_session(cfg_root_t *cfg, sqlite3 *sql, snprintf(szStmt, sizeof szStmt, "DELETE FROM %s WHERE ConnID = '%s' AND Username = '%s' " "AND RemoteHost LIKE '%s';", str, connid, user, host); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -182,7 +170,6 @@ mqtt_rtlm_fini_session(cfg_root_t *cfg, sqlite3 *sql, ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -216,10 +203,8 @@ mqtt_rtlm_chk_session(cfg_root_t *cfg, sqlite3 *sql, c "ConnID = '%s' AND Username = '%s' AND RemoteHost LIKE '%s';", str, connid, user, host); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if (sqlite3_step(stmt) == SQLITE_ROW) @@ -227,7 +212,6 @@ mqtt_rtlm_chk_session(cfg_root_t *cfg, sqlite3 *sql, c else ret = 0; sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -266,10 +250,8 @@ mqtt_rtlm_write_topic(cfg_root_t *cfg, sqlite3 *sql, u "datetime('now', 'localtime'), '%s');", str, retain, msgid, topic, txt, user, host); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -280,7 +262,6 @@ mqtt_rtlm_write_topic(cfg_root_t *cfg, sqlite3 *sql, u ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -328,10 +309,8 @@ mqtt_rtlm_delete_topic(cfg_root_t *cfg, sqlite3 *sql, "PubUser LIKE '%s' AND PubHost LIKE '%s' %s;", str, msgid, topic, user, host, rtn); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -342,7 +321,6 @@ mqtt_rtlm_delete_topic(cfg_root_t *cfg, sqlite3 *sql, ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -390,10 +368,8 @@ mqtt_rtlm_read_topic(cfg_root_t *cfg, sqlite3 *sql, u_ "MsgID = %d AND Topic LIKE '%s' %s;", str, msgid, topic, szStr); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return NULL; } @@ -417,7 +393,6 @@ mqtt_rtlm_read_topic(cfg_root_t *cfg, sqlite3 *sql, u_ } end: sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return s; } @@ -455,10 +430,8 @@ mqtt_rtlm_write_subscribe(cfg_root_t *cfg, sqlite3 *sq "datetime('now', 'localtime'), '%s');", str, msgid, qos, topic, user, host); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -469,7 +442,6 @@ mqtt_rtlm_write_subscribe(cfg_root_t *cfg, sqlite3 *sq ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -482,15 +454,14 @@ mqtt_rtlm_write_subscribe(cfg_root_t *cfg, sqlite3 *sq * @topic = topic * @user = username * @host = hostname - * @qos = Subscribe QoS if -1 no matter * return: -1 error, 0 no changes or >0 deleted rows */ int mqtt_rtlm_delete_subscribe(cfg_root_t *cfg, sqlite3 *sql, const char *topic, - const char *user, const char *host, char qos) + const char *user, const char *host) { int ret = 0; - char *str, szStr[STRSIZ] = { 0 }, szStmt[BUFSIZ] = { 0 }; + char *str, szStmt[BUFSIZ] = { 0 }; sqlite3_stmt *stmt; if (!cfg || !sql || !topic) @@ -501,16 +472,12 @@ mqtt_rtlm_delete_subscribe(cfg_root_t *cfg, sqlite3 *s mqtt_rtlm_log("Error:: not found subscribes table name"); return -1; } - if (qos > -1 && qos < 3) - snprintf(szStr, sizeof szStr, "AND QoS = %d", qos); snprintf(szStmt, sizeof szStmt, "DELETE FROM %s WHERE Topic LIKE '%s' AND " - "PubUser LIKE '%s' AND PubHost LIKE '%s' %s;", str, - topic, user, host, szStr); + "PubUser LIKE '%s' AND PubHost LIKE '%s';", str, + topic, user, host); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return -1; } if ((ret = sqlite3_step(stmt)) == SQLITE_DONE) @@ -521,7 +488,6 @@ mqtt_rtlm_delete_subscribe(cfg_root_t *cfg, sqlite3 *s ret = 0; } sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return ret; } @@ -553,10 +519,8 @@ mqtt_rtlm_read_subscribe(cfg_root_t *cfg, sqlite3 *sql } snprintf(szStmt, sizeof szStmt, "SELECT QoS, Topic FROM %s WHERE Topic LIKE '%s';", str, topic); - sqlite3_mutex_enter(sqlite3_db_mutex(sql)); if (sqlite3_prepare_v2(sql, szStmt, strlen(szStmt), &stmt, NULL)) { MQTT_RTLM_LOG(sql); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return NULL; } @@ -580,7 +544,6 @@ mqtt_rtlm_read_subscribe(cfg_root_t *cfg, sqlite3 *sql } end: sqlite3_finalize(stmt); - sqlite3_mutex_leave(sqlite3_db_mutex(sql)); return s; }